Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds 3 optional graphs to Ongeki scores:
The provided data is the Y axis. The X axis is presumed to increase in 1-second intervals. The score provider is trusted with padding the array with
null
s in case of an early forfeit.Because Ongeki scores are very top-heavy, I capped score− at S (970k), the lowest score that can be considered relevant. Another option could be to scale the Y axis depending on the score.
The scale of the bell chart's Y axis depends on the number of bells that could have been obtained at the time of forfeit. If that's a blocker, one solution would be to add total bell counts to seeds and expose them to the client; alternatively, add another optional field and expect the score provider to fill it every time.