Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ongeki): graphs #1214

Merged
merged 3 commits into from
Dec 10, 2024
Merged

feat(ongeki): graphs #1214

merged 3 commits into from
Dec 10, 2024

Conversation

nyairobi
Copy link
Contributor

This branch adds 3 optional graphs to Ongeki scores:

  • Score−
  • Missed bells
  • Life gauge

The provided data is the Y axis. The X axis is presumed to increase in 1-second intervals. The score provider is trusted with padding the array with nulls in case of an early forfeit.

Because Ongeki scores are very top-heavy, I capped score− at S (970k), the lowest score that can be considered relevant. Another option could be to scale the Y axis depending on the score.

The scale of the bell chart's Y axis depends on the number of bells that could have been obtained at the time of forfeit. If that's a blocker, one solution would be to add total bell counts to seeds and expose them to the client; alternatively, add another optional field and expect the score provider to fill it every time.

Screenshot_20241210_012833

I don't know why it doesn't complain about other files.
I don't know why the server check failed. Works on my machine.
@zkrising
Copy link
Owner

Thanks for the details. I don't think the bell thing is much of a blocker. Seems like a reasonable limitation to me -- and one that we can fix in the future when we have that information.

This is excellent stuff. Thank you for this!

@zkrising zkrising merged commit 4dc26a4 into zkrising:main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants