feat: MAIT Integration #964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can probably see where i referenced the code from
|
is this ready for review? |
Should be now. |
seems pretty silly but myt can be confused for another network.
|
Renamed |
beer-psi
force-pushed
the
feat/myt-integration
branch
from
2452ff7 to
3b8bcb0
Compare
|
i don't get this. they provide an API that exports scores in batch manual. Why can't they just post it to I don't think I'll accept this PR because the onus is on them to do the rest of the integration here. There's no need for us to lug around code like this when we've done all the work for them. |
|
yeah as far as i'm concerned this is a poor solution to something that isn't our problem. Users shouldn't need to paste this API key in at all - we provide an OAuth2 api that does all of this stuff and they already work in terms of batch manual. They need to develop this, not us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MAIT as an import method for maimai. Since they do not have OAuth, users must manually enter an API token, which is never shown in the client.