fix: header overflow #980
Merged
fix: header overflow #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a bug introduced by a previous "fix"
zkrising
pushed a commit
that referenced
this pull request
Dec 12, 2023
fixes a bug introduced by a previous "fix"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous attempt to fix a bug where the sign out button was fixed in place overlaying menu elements, I created an overflow container within the menu container which already has overflow properties applied. This results in an issue where the header always overflows across all breakpoints breaking the menus on desktop displays. The actual fix is to move the sign-out button outside of said container so it's statically positioned at the end of the offcanvas.