Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: correct type matching in if-else expression #264

Merged
merged 1 commit into from
Jan 22, 2025
Merged

bug-fix: correct type matching in if-else expression #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/mast/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,17 @@ fn monomorphize_expr<B: Backend>(
let else_mono = monomorphize_expr(ctx, else_, mono_fn_env)?;

// make sure that the type of then_ and else_ match
if then_mono.typ != else_mono.typ {
let is_match = match (&then_mono.typ, &else_mono.typ) {
// generics not allowed as they should have been monomorphized
(Some(then_typ), Some(else_typ)) => then_typ.match_expected(else_typ, true),
_ => Err(Error::new(
"If-Else Monomorphization",
ErrorKind::UnexpectedError("Could not resolve type for the `if-else` branch"),
expr.span,
))?,
};

if !is_match {
Err(Error::new(
"If-Else Monomorphization",
ErrorKind::UnexpectedError(
Expand Down
Loading