Skip to content

feat: prioratize EIP712 and utilize zks_estimateFee #367

feat: prioratize EIP712 and utilize zks_estimateFee

feat: prioratize EIP712 and utilize zks_estimateFee #367

Triggered via pull request July 14, 2024 22:37
Status Failure
Total duration 26s
Artifacts

validate.yml

on: pull_request
Check code format
17s
Check code format
Check commits
15s
Check commits
Check commits from forks
0s
Check commits from forks
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 4 warnings
Check code format: src/signer.ts#L652
Insert `⏎······`
Check code format: src/signer.ts#L655
Insert `⏎····`
Check code format: src/signer.ts#L657
Replace `⏎········?·address⏎·······` with `·?·address`
Check code format: src/signer.ts#L671
Delete `⏎·········`
Check code format: src/signer.ts#L686
Replace `transaction:·TransactionRequest` with `⏎····transaction:·TransactionRequest⏎··`
Check code format: src/signer.ts#L687
Insert `;`
Check code format: src/signer.ts#L696
Replace `"Provide·combination·of·maxFeePerGas·and·maxPriorityFeePerGas·or·provide·gasPrice.·Not·both!"` with `⏎········'Provide·combination·of·maxFeePerGas·and·maxPriorityFeePerGas·or·provide·gasPrice.·Not·both!'⏎······`
Check code format: src/signer.ts#L698
Insert `⏎······`
Check code format: src/signer.ts#L699
Insert `⏎··`
Check code format: src/smart-account-utils.ts#L202
Replace `populatedTx.gasPrice·&&·(populatedTx.maxFeePerGas·||·populatedTx.maxPriorityFeePerGas)` with `⏎····populatedTx.gasPrice·&&⏎····(populatedTx.maxFeePerGas·||·populatedTx.maxPriorityFeePerGas)⏎··`
Check code format: src/signer.ts#L696
Strings must use singlequote
Check code format: src/smart-account-utils.ts#L3
'Fee' is defined but never used
Check code format: src/smart-account-utils.ts#L203
Strings must use singlequote
Check code format: src/wallet.ts#L1410
Strings must use singlequote