Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for checkBaseCost #18

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Conversation

WillXing
Copy link
Contributor

What πŸ’»

  • Add unit test for checkBaseCost

Why βœ‹

  • Increase test coverage in utils

Evidence πŸ“·

Note: Test coverage by only run tests in tests/unit/util.test.ts

Before

Screenshot 2023-12-22 at 11 36 01 PM

After

Screenshot 2023-12-22 at 11 38 26 PM

@danijelTxFusion
Copy link
Collaborator

@WillXing than you for contributing to this project. Please lint the source code with yarn:lint and rebase your commits order to follow conventional commits. There should be one commit:

test: add unit test for `util.checkBaseCost`

@WillXing
Copy link
Contributor Author

WillXing commented Jan 7, 2024

Thanks @danijelTxFusion , I'll take a look of the commits rebase soon

@WillXing
Copy link
Contributor Author

WillXing commented Jan 7, 2024

@danijelTxFusion should be all sorted now.

@danijelTxFusion danijelTxFusion merged commit 28d83cd into zksync-sdk:main Jan 7, 2024
4 checks passed
Copy link

πŸŽ‰ This PR is included in version 6.1.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants