Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plot_cpdb3.R #94

Closed
wants to merge 1 commit into from
Closed

Update plot_cpdb3.R #94

wants to merge 1 commit into from

Conversation

WeberKang
Copy link

factor to character

factor to character
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b249e8) 70.47% compared to head (a44dc34) 70.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   70.47%   70.49%   +0.01%     
==========================================
  Files           9        9              
  Lines        2161     2162       +1     
==========================================
+ Hits         1523     1524       +1     
  Misses        638      638              
Files Coverage Δ
R/plot_cpdb3.R 75.70% <100.00%> (+0.11%) ⬆️

@zktuong
Copy link
Owner

zktuong commented Dec 29, 2023

Thank you for the PR. I will review it properly next week when i’m back at work

@zktuong
Copy link
Owner

zktuong commented Dec 29, 2023

Hi @WeberKang,

i had a look and this is not the fix required. instead of using 3, i need to change it to the actual column name (means or scaled_means)

@zktuong zktuong closed this Dec 29, 2023
@WeberKang
Copy link
Author

ok,this is a great tool. wish you a happy holiday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants