-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the zcrypto dependency to bring in TLS 1.3 support #507
base: master
Are you sure you want to change the base?
Conversation
Looks like we'll need to update the zschema definitions in zcrypto for the integration tests to pass. @developStorm would you have the bandwidth to take a look at this? |
The old Read method was incorrectly implemented as ReadFull, causing it to wait indefinitely for a new packet that may never arrive under certain conditions.
360ed15
to
06558a0
Compare
@phillip-stephens Thanks for the heads up, fixed zschemas! ZGrab on this branch is currently tracking an unmerged commit of ZCrypto zmap/zcrypto#412 to allow the integration test to pass. We should merge the ZCrypto PR first before proceeding with this one. Additionally, the Python integration test now pulls schemas from a specific version of ZCrypto instead of the latest The test failure took longer to resolve due to an issue with the I also patched the integration test and Docker setup a bit with 9f512c2 to improve robustness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I guess you probably can't approve this PR because you created it @phillip-stephens. I'll just approve this and you can rebase/merge it if it looks good.
Add a description of your changes here.
How to Test
Add brief instructions on how to test your changes.
Notes & Caveats
If necessary, explain the motivation for this PR, and note any caveats that apply to your changes or future work that will be needed.
Issue Tracking
Add a link to the relevant GitHub issue(s) if the pull request resolves it.