Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with running subset of integration tests #510

Merged
merged 7 commits into from
Mar 20, 2025

Conversation

phillip-stephens
Copy link
Contributor

Before, there was an issue when trying to run a subset of the integration tests.

~/zgrab2 on  master! ⌚ 14:11:06
$ TEST_MODULES="amqp091" make integration-test

docker compose -p zgrab -f integration_tests/docker-compose.yml build amqp091
no such service: amqp091
make: *** [Makefile:32: integration-test] Error 1

The issue is that the docker containers have module_name and a version, usually.

$ docker compose -p zgrab -f integration_tests/docker-compose.yml config --services | grep "amqp"
amqp091-3.12.14
amqp091-3.13.2

This PR searches for docker containers that contain the module_name, ensuring desired behavior.

@phillip-stephens phillip-stephens marked this pull request as ready for review March 20, 2025 05:15
@phillip-stephens phillip-stephens requested a review from zakird March 20, 2025 05:22
@zakird zakird merged commit 2a04bc5 into master Mar 20, 2025
5 checks passed
@zakird zakird deleted the phillip/run-subset-of-integration-tests branch March 20, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants