Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused exclude for ruby 2.2 in ci.yml #216

Merged
merged 2 commits into from
May 24, 2024
Merged

Remove unused exclude for ruby 2.2 in ci.yml #216

merged 2 commits into from
May 24, 2024

Conversation

andrew
Copy link
Contributor

@andrew andrew commented May 21, 2024

Ruby 2.2 support was removed in 30e3f6f

@wuputah
Copy link
Collaborator

wuputah commented May 22, 2024

Yes, thanks! Also the README should be updated. The addition of +"syntax" in #196 means we are Ruby 2.3+ only, though if someone really needs Ruby <2.3 we could swap that with String.new. rack-timeout usage is pretty widespread but I'll wait for the issue / PR… 😁

@andrew
Copy link
Contributor Author

andrew commented May 23, 2024

@wuputah updated the readme too

@wuputah wuputah merged commit d37a765 into zombocom:main May 24, 2024
@wuputah
Copy link
Collaborator

wuputah commented May 24, 2024

thanks again!

@andrew andrew deleted the patch-1 branch May 25, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew @wuputah