Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First Beta: Spice Islands #171

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

First Beta: Spice Islands #171

wants to merge 42 commits into from

Conversation

JorenC
Copy link
Contributor

@JorenC JorenC commented Feb 21, 2023 •
edited
Loading

This PR is 2 of 3 of 3 changes. This one needs to be done after the Distribution List in Diplicity has been updated.

@tttppp could you pull this one (and also 1 - unless you don't have access) and let me know when it happened?
After that I'll update the BETA API level for Dipact to test if it works.

  1. Add Spice Islands to the distribution list in Diplicity to ensure it has a high enough API level to not be picked up by clients.
    Add all variants and Spice Islands as Beta diplicity#177
    2) Release Spice Island to Godip to ensure it is available
  2. Raise the Dipact "X-Diplicity-API-Level": "8" to "9"

Note that this is a build-anywhere variant, which SHOULD work
Note that I've made one other change - I changed the fleet in Hundred (the old one was TERRIBLE UGLY).

@JorenC
Hello World
9166cc4
@JorenC
7 edges
73d14e4
@JorenC
HellowWorld2
6f4fe13
@JorenC
First Working Version
778df1a
@JorenC
Next Step
bcae3b0
@JorenC
Done-ish
8636d1e 
Need:
- Multiple Coasts
- One annoying province
- Chinese Empire
- Build anywhere
@JorenC
Updated YML file
89782d1 
Fixing the greedy algorithm - and thus another generator pass
@JorenC
Build Anywhere
cd3e827 
Added Build Anywhere logic
@JorenC
Update bindata.go
a0910ae
@JorenC
Update Hundred units
d84952c
@JorenC
Merge branch 'spiceislands' of https://github.com/JorenC/godip into s…
1f43ac8 
…piceislands
@JorenC
Add buildanywhere
6b4d8fd
@JorenC
Map 100% + bindata
e9f162f
@JorenC
MOVE EMPIRES DOWN
65c050a 
This variant bugs the generator and should be at the bottom
@JorenC
Add hundred units & fix empires
4e5b143
@JorenC
Add ThreeKingdoms
7827101
@JorenC
Merge branch 'spiceislands' of https://github.com/JorenC/godip into s…
fef6334 
…piceislands
@JorenC
Change units to Sengoku
a47bdd1
@JorenC
Add South America
87a2fa9
@JorenC
Merge branch 'spiceislands' of https://github.com/JorenC/godip into s…
786e4f8 
…piceislands
@JorenC
Remove SouthAmerica (buggy)
c49c5bc
@JorenC
Split Anding and Hedong province - bugfix
0567f6b
@JorenC
Fix missing SC
7a72b73
@JorenC
Fix missing SC
9221221
@JorenC
Fix two provinces being mishandled by the greedy algorithm
809db83
@JorenC
Remove all except Spice Islands (buggy)
1289770
@JorenC
FINISHED
556e73a
@JorenC
Restore linux tests
2a35f87
@JorenC JorenC mentioned this pull request Feb 21, 2023
Open
@JorenC
Work in progress
edc6eab 
TODO:
- Add coasts (only added one)
- Add tests
@JorenC
Copy link
Contributor Author

JorenC commented Mar 5, 2023

@tttppp This one should now be completely ready to pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JorenC