Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to build with Libidn and LDNS in uncommon locations #152

Merged
5 commits merged into from Sep 5, 2022
Merged

Options to build with Libidn and LDNS in uncommon locations #152

5 commits merged into from Sep 5, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 24, 2022

Purpose

Provide options to facilitate building Zonemaster-LDNS with LDNS and Libidn installed in uncommon locations.

Context

addresses #129
follow-up on #134

Changes

New options:

  • --debug to get a more verbose output
  • --libidn-inc and --libidn-lib to specify where to look for Libidn files
  • --ldns-inc and --ldns-lib to specify where to look for LDNS files

How to test this PR

Manually build LDNS and/or Libidn (from source for instance), but do not install them. Then build Zonemaster-LDNS with these libraries:

perl Makefile.PL --ldns-inc /tmp/ldns/ --ldns-lib /tmp/ldns/lib --libidn-inc /tmp/libidn/lib --libidn-inc /tmp/libidn/lib/.libs

Alexandre Pion added 3 commits August 24, 2022 17:02
Allow passing distinct LDNS and Libidn paths for include and library
files when configuring Zonemaster-LDNS.
@ghost ghost requested review from mattias-p and matsduf August 24, 2022 17:01
@matsduf
Copy link
Contributor

matsduf commented Aug 25, 2022

Please update README.md to make it consistent with the change.

@ghost ghost marked this pull request as draft August 25, 2022 08:37
@ghost ghost marked this pull request as ready for review August 25, 2022 08:42
@ghost ghost merged commit cc43f4b into zonemaster:develop Sep 5, 2022
@ghost ghost deleted the build-paths branch September 5, 2022 12:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant