Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes regarding closing sessions when working with streams #252

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

rossgeesman
Copy link
Contributor

Our team thought the docs could be more explicit about how to handle sessions when consuming Mongo.Streams. Let me know if these updates are clear, I'm happy to make any changes or improvements if needed.

Copy link
Owner

@zookzook zookzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Not only is the session process no longer terminated, but you would only receive the first batch. The results are sent to the client in batches.

@zookzook zookzook merged commit 6854323 into zookzook:master Sep 20, 2024
3 of 4 checks passed
@zookzook
Copy link
Owner

I have also updated the Readme.md file to emphasize the handling of the Mongo.Stream struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants