fix: propagate change of value to all services and decorators

zoomsphere · Feb 17, 2018 · 4e5486b · 4e5486b
1 parent abe709b
commit 4e5486b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/decorator/cache-item.ts b/src/decorator/cache-item.ts
@@ -162,7 +162,7 @@ export class CacheItem implements CacheItemInterface {
         this.proxy = null;
     }
 
-    protected propagateChange(value: any, source) {
+    public propagateChange(value: any, source) {
         if (isEqual(value, this.readValue())) return;
         this.utilities.forEach(entry => {
             const utility = entry.utility;

diff --git a/src/utility/webstorage.utility.ts b/src/utility/webstorage.utility.ts
@@ -94,6 +94,7 @@ export class WebStorageUtility {
             if (cacheItem) {
                 debug.log(`updating following CacheItem from ${this.constructor.name}:`, cacheItem);
                 cacheItem.resetProxy();
+                cacheItem.propagateChange(value, this);
             }
         } catch (error) {
             console.warn(`[ngx-store] ${this.getStorageName()}: following error occurred while trying to save ${key} =`, value);

diff --git a/tests/decorator/webstorage.spec.ts b/tests/decorator/webstorage.spec.ts
@@ -137,7 +137,7 @@ describe('Decorators', () => {
         sessionStorageService.set('sessionStorageVariable', 44);
         cookiesStorageService.remove('cookieStorageVariable');
         sharedStorageService.set('sharedStorageVariable', {a: 4});
-        sessionStorageService.set('twoDecorators', 44); // TODO make it working with change in sharedStorageService
+        sharedStorageService.set('twoDecorators', 44);
         sessionStorageService.set('customKeyVariable', ['']);
         cookiesStorageService.update('customObject', {anotherProperty: []});
         sharedStorageService.set('arrayOfObjects', []);