Add tests for onSubjectAdvance middleware

Override the mock feedback store with stores that have active and inactive feedback. Test the middleware for both cases.
zooniverse · Mar 20, 2019 · aeaefc7 · aeaefc7
1 parent 8a33b93
commit aeaefc7
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 3 deletions.
diff --git a/packages/lib-classifier/src/store/FeedbackStore.js b/packages/lib-classifier/src/store/FeedbackStore.js
@@ -131,6 +131,7 @@ const FeedbackStore = types
       setOnHide,
       showFeedback,
       hideFeedback,
+      onSubjectAdvance,
       update,
       reset
     }

diff --git a/packages/lib-classifier/src/store/FeedbackStore.spec.js b/packages/lib-classifier/src/store/FeedbackStore.spec.js
@@ -127,9 +127,6 @@ describe('Model > FeedbackStore', function () {
 
   describe('hideFeedback', function () {
     beforeEach(function () {
-      feedback.subjects = {
-        advance: () => true
-      }
       feedback.setOnHide(sinon.stub())
       feedback.hideFeedback()
     })
@@ -160,4 +157,46 @@ describe('Model > FeedbackStore', function () {
       expect(feedback.hideSubjectViewer).to.equal(false)
     })
   })
+
+  describe('when the subject queue advances', function () {
+    const call = {
+      name: 'advance',
+      args: []
+    }
+    const next = sinon.stub()
+    const abort = sinon.stub()
+
+    describe('when feedback is inactive', function () {
+      beforeEach(function () {
+        feedback = FeedbackStore.create({ isActive: false })
+        feedback.onSubjectAdvance(call, next, abort)
+      })
+
+      it('should continue the action', function () {
+        expect(next.withArgs(call)).to.have.been.calledOnce
+      })
+    })
+
+    describe('when feedback is active', function () {
+      beforeEach(function () {
+        feedback = FeedbackStore.create(feedbackStub)
+        feedback.subjects = {
+          advance: sinon.stub()
+        }
+        feedback.onSubjectAdvance(call, next, abort)
+      })
+
+      it('should abort the action', function () {
+        expect(abort).to.have.been.calledOnce
+      })
+
+      it('should show feedback', function () {
+        expect(feedback.showModal).to.be.true
+      })
+
+      it('should set the onHide callback', function () {
+        expect(feedback.onHide).to.equal(feedback.subjects.advance)
+      })
+    })
+  })
 })