-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib-user: Setup react-i18next for Contributors components #6553
Conversation
@mcbouslog this is the base of multiple branches that add react-i18next to lib-user, and I'm tagging you for review of all PRs. I split up this feature to make it easier for review since these are live webpages. Please feel free to review in whichever order you prefer, and the PRs are tagged in the project board, too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and related lib-user translation PRs look good. I've tested locally to make sure pages continue to load as expected. 👍 🌐
Is adding the test: "Test Language"
to the storybook preview.js
and related translation JSON a reasonable addition to these changes or is that something that should be in a different PR? While I noted no issues testing these changes locally, changing the language (to the "Test Language") in storybook would provide additional assurance.
useTranslation as useBaseTranslation | ||
} from 'react-i18next' | ||
|
||
const libI18n = i18n.createInstance() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is trivial, but if lib-classifier creates classifierI18n
and lib-react-components creates zrcI18n
, should this be less generic and include user
or a related abbreviation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point! I'll rename to libUserI18n
* setup react-i18next for GroupStats components * lib-user: Setup react-i18next for MyGroups components (#6555) * Setup react-i18next for MyGroups components * lib-user: Setup react-i18next for UserHome components (#6556) * Setup react-i18next for UserHome components * lib-user: Setup react-i18next for BarChart and GroupContainer (#6557) * Setup react-i18next for BarChart and GroupContainer * add translations for DeactivatedGroup * lib-user: Setup react-i18next for GroupForm (#6558) * Setup react-i18next translations for GroupForm components * lib-user: Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects (#6559) * Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects * Setup react-i18next for MainContent components (#6561)
Re: Test Language dictionary - I'm going to merge this translations branch, pull the new English dictionary into Lokalise, and then have Lokalise generate a new Test Language json dictionary for me. Along with that dictionary PR, I'll enable translations in Storybook on our way to introducing localization in the app-root Next.js router. |
Package
lib-user
Linked Issue and/or Talk Post
This is the start of a chain of translations PRs. The next one is #6554
Describe your changes
How to Review
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrap
ordocker-compose up --build
and FEM works as expectedNew Feature
Post-merge