Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-user: Setup react-i18next for BarChart and GroupContainer #6557

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

goplayoutside3
Copy link
Contributor

@goplayoutside3 goplayoutside3 commented Dec 15, 2024

Package

lib-user

Linked Issue and/or Talk Post

This builds on top of #6556

Describe your changes

Setup react-i18next for BarChart and GroupContainer components

How to Review

The expected text should display for the BarChart and GroupContainer components when lib-user is run locally, in Storybook, or as app-root pages.

Checklist

PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.

General

  • Tests are passing locally and on Github
  • Documentation is up to date and changelog has been updated if appropriate
  • You can yarn panic && yarn bootstrap or docker-compose up --build and FEM works as expected
  • FEM works in all major desktop browsers: Firefox, Chrome, Edge, Safari (Use Browserstack account as needed)

New Feature

  • The PR creator has listed user actions to use when testing the new feature
  • Unit tests are included for the new feature
  • A storybook story has been created or updated
    • Example of SlideTutorial component with docgen comments, and its story

Post-merge

  • This PR adds translations keys to English dictionary(s). See guidance for pulling new keys to Lokalise here.

@goplayoutside3 goplayoutside3 added the translations Involves managing text translation label Dec 15, 2024
@goplayoutside3
Copy link
Contributor Author

I purposely ignored the x-axis labels in this PR. For instance, there's a "Date Range UTC" label set via a psuedo element that in theory should also be translated, but I'd like to wait until I get a Test Lang dictionary setup to fine-tune the BarChart.

@mcbouslog mcbouslog self-assigned this Dec 26, 2024
Copy link
Contributor

@mcbouslog mcbouslog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally; LGTM!

@github-actions github-actions bot added the approved This PR is approved for merging label Dec 26, 2024
@mcbouslog mcbouslog removed their assignment Dec 26, 2024
* Setup react-i18next translations for GroupForm components

* lib-user: Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects (#6559)

* Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects

* Setup react-i18next for MainContent components (#6561)
@goplayoutside3 goplayoutside3 merged commit 141b73d into translations-user-home Jan 6, 2025
5 checks passed
@goplayoutside3 goplayoutside3 deleted the translations-shared-one branch January 6, 2025 18:53
goplayoutside3 added a commit that referenced this pull request Jan 6, 2025
* Setup react-i18next for UserHome components

* lib-user: Setup react-i18next for BarChart and GroupContainer (#6557)

* Setup react-i18next for BarChart and GroupContainer

* add translations for DeactivatedGroup

* lib-user: Setup react-i18next for GroupForm (#6558)

* Setup react-i18next translations for GroupForm components

* lib-user: Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects (#6559)

* Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects

* Setup react-i18next for MainContent components (#6561)
goplayoutside3 added a commit that referenced this pull request Jan 6, 2025
* Setup react-i18next for MyGroups components

* lib-user: Setup react-i18next for UserHome components (#6556)

* Setup react-i18next for UserHome components

* lib-user: Setup react-i18next for BarChart and GroupContainer (#6557)

* Setup react-i18next for BarChart and GroupContainer

* add translations for DeactivatedGroup

* lib-user: Setup react-i18next for GroupForm (#6558)

* Setup react-i18next translations for GroupForm components

* lib-user: Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects (#6559)

* Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects

* Setup react-i18next for MainContent components (#6561)
goplayoutside3 added a commit that referenced this pull request Jan 6, 2025
* setup react-i18next for GroupStats components

* lib-user: Setup react-i18next for MyGroups components (#6555)

* Setup react-i18next for MyGroups components

* lib-user: Setup react-i18next for UserHome components (#6556)

* Setup react-i18next for UserHome components

* lib-user: Setup react-i18next for BarChart and GroupContainer (#6557)

* Setup react-i18next for BarChart and GroupContainer

* add translations for DeactivatedGroup

* lib-user: Setup react-i18next for GroupForm (#6558)

* Setup react-i18next translations for GroupForm components

* lib-user: Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects (#6559)

* Setup react-i18next for HeaderDropdown, ProfileHeader, and TopProjects

* Setup react-i18next for MainContent components (#6561)
goplayoutside3 added a commit that referenced this pull request Jan 7, 2025
* setup react-i18next for Contributors components

* lib-user: Setup react-i18next for GroupStats components (#6554)

* lib-user: Setup react-i18next for MyGroups components (#6555)

* lib-user: Setup react-i18next for UserHome components (#6556)

* lib-user: Setup react-i18next for BarChart and GroupContainer (#6557)

* lib-user: Setup react-i18next for GroupForm (#6558)

* Setup react-i18next for MainContent components (#6561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved for merging translations Involves managing text translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants