remove shared class implementation

zooniverse · Nov 5, 2024 · 148e2b6 · 148e2b6
1 parent f666b78
commit 148e2b6
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 70 deletions.
diff --git a/app/modules/label_extractors/galaxy_zoo/base_extractor.rb b/app/modules/label_extractors/galaxy_zoo/base_extractor.rb
@@ -36,9 +36,13 @@ def self.data_labels
         self::TASK_KEY_DATA_LABELS
       end
 
-      # Base version of question_answers_schema method to be customized by subclasses
+      # provide a flat task question and answers list for the decals mission catalogues
       def self.question_answers_schema
-        raise NotImplementedError, "Subclass must define `question_answers_schema`"
+        label_prefixes.map do |task_key, question_prefix|
+          data_labels[task_key].values.map do |answer_suffix|
+            "#{question_prefix}-#{data_release_suffix}_#{answer_suffix}"
+          end
+        end.flatten
       end
 
       private

diff --git a/app/modules/label_extractors/galaxy_zoo/cosmic_dawn.rb b/app/modules/label_extractors/galaxy_zoo/cosmic_dawn.rb
@@ -2,7 +2,7 @@
 
 module LabelExtractors
   module GalaxyZoo
-    class CosmicDawn < LabelExtractors::Shared::CosmicDawnAndEuclid
+    class CosmicDawn < BaseExtractor
 
       # GZ decision tree task schema and lable tables
       #

diff --git a/app/modules/label_extractors/galaxy_zoo/euclid.rb b/app/modules/label_extractors/galaxy_zoo/euclid.rb
@@ -2,7 +2,7 @@
 
 module LabelExtractors
   module GalaxyZoo
-    class Euclid < LabelExtractors::Shared::CosmicDawnAndEuclid
+    class Euclid < BaseExtractor
 
       attr_reader :task_lookup_key, :task_prefix_label
 

diff --git a/app/modules/label_extractors/shared/cosmic_dawn_and_euclid.rb b/app/modules/label_extractors/shared/cosmic_dawn_and_euclid.rb
diff --git a/spec/modules/label_extractors/shared/cosmic_dawn_and_euclid_spec.rb b/spec/modules/label_extractors/shared/cosmic_dawn_and_euclid_spec.rb