[issue-4351] hound cleanups

app/controllers/api/v1/users_controller.rb

@@ -50,8 +50,8 @@ def update
     prev_email = user.email
     super do |user|
       if user.email_changed?
-        user.update_attribute(:valid_email, true)
-        UserInfoChangedMailerWorker.perform_async(user.id, "email", prev_email)
+        user.update(valid_email: true)
+        UserInfoChangedMailerWorker.perform_async(user.id, 'email', prev_email)
       end
     end
   end

app/mailers/user_info_changed_mailer.rb

@@ -4,7 +4,7 @@ class UserInfoChangedMailer < ApplicationMailer
   def user_info_changed(user, info, previous_email=nil)
     @user = user
     @recipient_emails = [user.email]
-    @recipient_emails << previous_email if previous_email.present? && info == "email"
+    @recipient_emails << previous_email if previous_email.present? && info == 'email'
 
     case info
     when "email"
@@ -15,6 +15,6 @@ def user_info_changed(user, info, previous_email=nil)
       template = "password_changed"
     end
 
-    mail(to: @recipient_emails, subject: 'Limited subject', :template_name => template )
+    mail(to: @recipient_emails, subject: subject, template_name: template )
   end
 end

spec/controllers/api/v1/users_controller_spec.rb

@@ -473,13 +473,13 @@ def update_request
 
     context "when changing email" do
       let(:put_operations) { {users: {email: "[email protected]"}} }
-      let!(:user_email){ user.email }
+      let!(:user_email) { user.email }
 
       after(:each) do
         update_request
       end
 
-      it "sends an email to the new address if user is valid", focus: true do
+      it "sends an email to the new address if user is valid" do
         expect(UserInfoChangedMailerWorker).to receive(:perform_async).with(user.id, "email", user_email)
       end