-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust User group search to mimic user search #4291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name specs with shorter name
Pinging @mcbouslog so that he and I can test against zooniverse/Panoptes-Front-End#6968 once this change is merged into staging |
zwolf
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of User Groups stats effort. See: FE Stats Project Board here: https://github.com/orgs/zooniverse/projects/36/views/2?pane=issue&itemId=41487549
Want is to mimic user_group admin search to mimic that of user search. (But in our case instead of searching by
user.login
we search byuser_group.display_name
(not a unique field)).Compared to the last migration where we added a
tsv
column. https://github.com/zooniverse/panoptes/blob/master/db/migrate/archive/20151210134819_add_tsvector_to_projects.rb there are a couple differences:safety_assured
on the creation of sql triggerReview checklist
apiary.apib
file?