append current time to copied project display name #4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcjohnso
requested changes
May 22, 2024
lib/project_copier.rb
Outdated
Comment on lines
64
to
66
| current_timestamp = Time.now.utc.strftime('%Y-%m-%d %H:%M:%S') | ||
| copied_project.display_name += ' (copy)' if user == project_to_copy.owner | ||
| copied_project.display_name += " #{current_timestamp}" |
There was a problem hiding this comment.
Following method used in workflow_copier.rb (see workflow_copier.rb#L22), and removing if user == owner (that doesn't seem necessary since all workflows will have a unique copy tag added.
Suggested change
| current_timestamp = Time.now.utc.strftime('%Y-%m-%d %H:%M:%S') | |
| copied_project.display_name += ' (copy)' if user == project_to_copy.owner | |
| copied_project.display_name += " #{current_timestamp}" | |
| copied_project.display_name += " (copy: #{Time.now.utc.strftime('%Y-%m-%d %H:%M:%S')})" |
spec/lib/project_copier_spec.rb
Outdated
| expect(copied_project.display_name).to eq(project.display_name) | ||
| it 'appends current timestamp to display_name' do | ||
| allow(Time).to receive(:now).and_return(Time.utc(2024, 5, 17, 12, 0, 0)) | ||
| expect(copied_project.display_name).to eq("#{project.display_name} 2024-05-17 12:00:00") |
There was a problem hiding this comment.
If suggestion above is used, then here is the fix for the spec.
Suggested change
| expect(copied_project.display_name).to eq("#{project.display_name} 2024-05-17 12:00:00") | |
| expect(copied_project.display_name).to eq("#{project.display_name} (copy: 2024-05-17 12:00:00)") |
|
FYI: you can choose to "commit suggestion" from review comments when they are available -- that might be faster than creating those edits / commits on your own. |
Yeah, i'll do going forward. Just wanted to reconfirm with the tests locallt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change here.
Review checklist
apiary.apibfile?