Batch Aggregation mailer #4352
Merged
Batch Aggregation mailer #4352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuenmichelle1
approved these changes
Jun 27, 2024
|
|
||
| def perform(agg_id) | ||
| aggregation = Aggregation.find(agg_id) | ||
| AggregationCompletedMailer.aggregation_complete(aggregation).deliver |
There was a problem hiding this comment.
I think .deliver might be a deprecated method replaced by deliver_now or deliver_later
There was a problem hiding this comment.
apparently so! Every other mailer uses it, but I'll just change it here and leave that refactor for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the params to AggregationsController#update include a change to status, send an email to the associated user that includes the links to the output files if the run was successful. "Complete" here means either succeeded or failed.
Review checklist
apiary.apibfile?