Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate List, Set and Dict check for In and NotIn #132

Merged
merged 3 commits into from
Oct 2, 2018
Merged

separate List, Set and Dict check for In and NotIn #132

merged 3 commits into from
Oct 2, 2018

Conversation

loechel
Copy link
Member

@loechel loechel commented Oct 2, 2018 •
edited
Loading

this partially solves issue #113

@loechel loechel requested a review from icemac October 2, 2018 09:37
@loechel loechel mentioned this pull request Oct 2, 2018
Closed
@loechel loechel changed the title seperate List, Set, Dict and Object check for In and NotIn separate List, Set and Dict check for In and NotIn Oct 2, 2018
icemac
icemac approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides some missing not's

tests/transformer/test_comparators.py Outdated

@pytest.mark.parametrize(*e_eval)
def test_RestrictingNodeTransformer__visit_NotIn_Dict(e_eval):
"""It allows `in` expressions."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be not in.

tests/transformer/test_comparators.py Outdated

@pytest.mark.parametrize(*e_eval)
def test_RestrictingNodeTransformer__visit_NotIn_Set(e_eval):
"""It allows `in` expressions."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows not in

tests/transformer/test_comparators.py Outdated
"""It allows `in` expressions."""
assert e_eval('2 in [1, 2, 3]') is True


@pytest.mark.parametrize(*e_eval)
def test_RestrictingNodeTransformer__visit_NotIn__1(e_eval):
def test_RestrictingNodeTransformer__visit_NotIn_List(e_eval):
"""It allows `in` expressions."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows not in.

@loechel loechel merged commit fd4ddad into master Oct 2, 2018
@loechel loechel deleted the in_not_in_sep branch October 2, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loechel @icemac