Add support for Python 3.12.

[icemac]

Isort imports.

[coveralls]

Pull Request Test Coverage Report for Build 6900816393

• 176 of 192 (91.67%) changed or added relevant lines in 41 files are covered.
• 11 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+0.1%) to 73.469%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/ZEO/scripts/zeoup.py	0	1	0.0%
src/ZEO/tests/racetest.py	0	1	0.0%
src/ZEO/zeoctl.py	0	1	0.0%
src/ZEO/tests/stress.py	0	2	0.0%
src/ZEO/asyncio/futures.py	4	7	57.14%
src/ZEO/scripts/zeoqueue.py	0	4	0.0%
src/ZEO/scripts/zeoreplay.py	0	4	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/ZEO/asyncio/futures.py	1	83.69%
src/ZEO/scripts/parsezeolog.py	1	0.0%
src/ZEO/tests/speed.py	1	0.0%
src/ZEO/ClientStorage.py	2	90.5%
src/ZEO/scripts/timeout.py	2	0.0%
src/ZEO/scripts/zeoup.py	2	0.0%
src/ZEO/tests/InvalidationTests.py	2	86.18%

Totals
Change from base Build 5723019176:	0.1%
Covered Lines:	7794
Relevant Lines:	10124

---

💛 - Coveralls

[dataflake]

not sure why the Pypy3 tests fail

[d-maurer]

Jens Vagelpohl wrote at 2023-11-14 02:42 -0800:

@dataflake approved this pull request. not sure why the Pypy3 tests fail

This looks like the effect of a `print` statement (likely in server code). Usually, the (doc)test is likely already finished before the print is executed; here, a special load condition likely has let it happen during the `ZEO.DB` call.

[navytux]

@icemac, thanks for asking for review.

The first patch (Add support for Python 3.12) looks good to me.

The second patch (Isort imports): while I understand the rationale, when I look at the diff, for example at

-from ZODB.utils import p64, u64, z64, Lock, RLock
+from ZODB.utils import Lock
+from ZODB.utils import RLock
+from ZODB.utils import p64
+from ZODB.utils import u64
+from ZODB.utils import z64

to me it feels like the old version was better with higher signal to noise ratio.

But this is not a strong feeling and I won't object to this change if others find it convenient.

Kirill

[icemac]

not sure why the Pypy3 tests fail

PyPy3 prints some texts to stdout on GHA which break the doctests. I am going to ignore these texts.

[icemac]

But this is not a strong feeling and I won't object to this change if others find it convenient.

This is the default config for imports used in all other zopefoundation projects. We could change it here but I'd prefer not to do it.

[icemac]

Thank you for reviewing this PR. 😃