Use Py_REFCNT to access cPersistentObject refcounts #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These assertions failed to compile if built without `-DNDEBUG`. As of setuptools 75.7.0, setting `CFLAGS` to anything while building an extension no longer copies the `CFLAGS` that Python itself was built with, so `NDEBUG` is less likely to be defined. See pypa/setuptools#4836 and https://bugs.debian.org/1098602.
tseaver
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
LGTM, although I don't really follow the pypa discussion. In any case, using the Py_REFCNT macro[1] is cleaner than direct access.
[1] https://docs.python.org/3/c-api/refcounting.html#c.Py_REFCNT
|
The TL;DR is that the asserts couldn't actually be compiled with some Python versions and setuptools was masking that by adding |
|
Just released in https://pypi.org/project/persistent/6.1.1/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These assertions failed to compile if built without
-DNDEBUG. As of setuptools 75.7.0, settingCFLAGSto anything while building an extension no longer copies theCFLAGSthat Python itself was built with, soNDEBUGis less likely to be defined. See pypa/setuptools#4836 and https://bugs.debian.org/1098602.