Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests to support multipart 1.x+ versions. #8

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix tests to support multipart 1.x+ versions. #8

wants to merge 4 commits into from
+321 −747

Conversation

icemac
Copy link
Member

@icemac icemac commented Nov 21, 2024 •
edited
Loading

Open issues:

  • Fix the reaminaing tests

@icemac icemac requested a review from d-maurer November 21, 2024 08:59
@icemac icemac self-assigned this Nov 21, 2024
@icemac
Copy link
Member Author

icemac commented Nov 21, 2024

@d-maurer As a follow-up of the suggestions in zopefoundation/zope.app.publisher#18 I created this PR and fixed one of the doctests as a prof of concept.

What do you think about it?

d-maurer
d-maurer reviewed Nov 21, 2024
View reviewed changes
Copy link

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as proof of concept!

@icemac
Copy link
Member Author

icemac commented Nov 27, 2024

@d-maurer I'd put the encodeMultipartFormdata into zope.app.wsgi, so it can be reused. Do you think this is the right place?

@d-maurer
Copy link

d-maurer commented Nov 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-maurer d-maurer d-maurer left review comments

Assignees

@icemac icemac

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @d-maurer