Multi-phase module initialization #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the module initializer in preparation for future work.
Fix a likely leak in 'Message__reduce__' (introduced in PR #51).
Removes direct use of static 'MessageType' in 'Messsage_init'.
Note: currently depends on a static pointer to the type, but that
will be removed in the next commit, when we add module state to
hold that pointer.
Holds the pointer to the heap-allocated 'Message' type, instead of the static pointer added temporarily in the last commit.
It can't be *used* by the 'Message' type in Python < 3.9 (no way to navigate to the module) but we might find a way around that.
Post-module-creation logic moves to '_zim_module exec' slot.
Preserves the invariant, even though we still cannot navigate to it from methods of static types, which makes the 'is_message' impl still ugly.
dataflake
approved these changes
May 26, 2024
davisagli
reviewed
Jun 3, 2024
|
@davisagli Thanks so much for the close attention to detail! I know this stuff is hard to review, and I really appreciate the remote / async pairing. |
|
@tseaver I wouldn't count on myself to catch everything that might need to be noticed, but I'm finding it useful for practice reading C code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes making the
Messagetype heap-allocated for Python >= 3.9.I mean to port the mechanism developed here (allowing multi-phase for all Python verisons) to the
zope.interfacebranch in zopefoundation/zope.interface#301, which should make it suitable for merging.