Implemented Ultrasonic Sensor #43

aahsue · 2022-05-25T02:04:41Z

Description

Interfaced fullness class with ultrasonic sensor and ESP-32 .

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code improvement (a non-breaking change that improves the quality of the code)
Documentation Change (update to the documentation with no changes to the code)

Testing and Verification Instructions

Wire ESP-32 and ultrasonic sensor (trig pin 5, echo pin 18)
Build
Upload
Open serial monitor

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings

… are not implemented in this branch. this is based off of them theoretically being in our codebase. Co-authored-by: Lily Johnson <[email protected]>

… class Co-authored-by: Lily Johnson <[email protected]>

Co-authored-by: Lily Johnson <[email protected]>

patrickanguyen · 2022-05-25T02:39:28Z

src/fullnessTask.cpp

+            digitalWrite(trigPin, LOW);
+            vTaskDelay(1000 / portTICK_PERIOD_MS); // Delay for 1000 milliseconds
+            digitalWrite(trigPin, HIGH);
+            vTaskDelay(1000 / portTICK_PERIOD_MS); // Delay for 1000 milliseconds
+            digitalWrite(trigPin, LOW);


Add all of the library code to a new class called UltrasonicDistance that inherits from IDistance

patrickanguyen · 2022-05-25T02:40:09Z

src/fullnessTask.cpp


 using namespace Zotbins;

 static const char *name = "fullnessTask";
 static const int priority = 1;
 static const uint32_t stackSize = 4096;

+const int trigPin = 5;
+const int echoPin = 18;
+int amount = 0;


Does not need to be in global scope. Move to loop()

patrickanguyen · 2022-05-25T02:40:33Z

src/fullnessTask.cpp

+const int trigPin = 5;
+const int echoPin = 18;
+int amount = 0;
+std::vector<int32_t> distances;


Change to std::array because std::vector uses the heap

patrickanguyen · 2022-05-25T02:40:51Z

src/fullnessTask.cpp

+        // log_i("Hello from Fullness Task");
+
+        // distance sensor
+        // Fullness::IDistance distanceSensor;
+
+        // log_i();


dskin344

🤝

patrickanguyen · 2022-06-02T21:48:15Z

lib/Fullness/UltrasonicDistance.cpp

+int32_t UltrasonicDistance::startDistance()
+{
+    for (int i = 0; i < 8; i++)
+    {
+        digitalWrite(trigPin, LOW);
+        vTaskDelay(1000 / portTICK_PERIOD_MS); // Delay for 1000 milliseconds
+        digitalWrite(trigPin, HIGH);
+        vTaskDelay(1000 / portTICK_PERIOD_MS); // Delay for 1000 milliseconds
+        digitalWrite(trigPin, LOW);
+
+        long duration = pulseIn(echoPin, HIGH);
+        int32_t intDuration = duration * .034 / 2;
+
+        distances[i] = intDuration;
+    }
+}


Remove startDistance(). Just call 8 times in getDistance()

patrickanguyen · 2022-06-02T21:49:09Z

src/fullnessTask.cpp

@@ -1,13 +1,19 @@
 #include "fullnessTask.hpp"
 #include "FullnessMetric.hpp"
+#include "MockDistance.hpp"


Remove this - this is only for unit tests

patrickanguyen · 2022-06-02T21:49:18Z

src/fullnessTask.cpp

 #include <Arduino.h>
+#include <vector>


Remove this

patrickanguyen · 2022-06-02T21:49:29Z

src/fullnessTask.cpp

@@ -27,13 +33,22 @@ void FullnessTask::taskFunction(void *task)

 void FullnessTask::setup()
 {
+    Serial.begin(115200);


Remove this

patrickanguyen · 2022-06-02T21:50:24Z

src/fullnessTask.cpp

-        vTaskDelay(1000 / portTICK_PERIOD_MS); // Delay for 1000 milliseconds
-        log_i("Hello from Fullness Task");
+        log_i("made it 1");
+        Fullness::UltrasonicDistance ultrasonicSensor(trigPin, echoPin, 0);


Make ultrasonicDistance and FullnessMetric a member variable

aahsue and others added 5 commits May 12, 2022 14:08

NOT COMPLETE!! errors because Fullness class and mock Distance Sensor…

84c4ba8

… are not implemented in this branch. this is based off of them theoretically being in our codebase. Co-authored-by: Lily Johnson <[email protected]>

Merge branch 'main' into 24-create-unit-tests-for-fullness

b4f2e30

added unit tests for fullness using mock distance sensor and fullness…

4d41843

… class Co-authored-by: Lily Johnson <[email protected]>

fixed minor errors

a6ba363

interfaced fullness task with ESP-32 and ultrasonic sensor

c66f790

Co-authored-by: Lily Johnson <[email protected]>

aahsue requested review from patrickanguyen, sagarbpatel31, dskin344 and limenilbuz May 25, 2022 02:04

patrickanguyen requested changes May 25, 2022

View reviewed changes

dskin344 approved these changes May 25, 2022

View reviewed changes

finally made the changes sorry about the wait

d083e94

patrickanguyen requested changes Jun 2, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented Ultrasonic Sensor #43

Implemented Ultrasonic Sensor #43

aahsue commented May 25, 2022

patrickanguyen May 25, 2022

patrickanguyen May 25, 2022

patrickanguyen May 25, 2022

patrickanguyen May 25, 2022

dskin344 left a comment

patrickanguyen Jun 2, 2022

patrickanguyen Jun 2, 2022

patrickanguyen Jun 2, 2022

patrickanguyen Jun 2, 2022

patrickanguyen Jun 2, 2022

Implemented Ultrasonic Sensor #43

Are you sure you want to change the base?

Implemented Ultrasonic Sensor #43

Conversation

aahsue commented May 25, 2022

Description

Type of change

Testing and Verification Instructions

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dskin344 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment