Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track #'s should be forced as 2-digit values #32

Open
TrazhCant opened this issue Oct 12, 2023 · 2 comments · May be fixed by #157
Open

Track #'s should be forced as 2-digit values #32

TrazhCant opened this issue Oct 12, 2023 · 2 comments · May be fixed by #157

Comments

@TrazhCant
Copy link

Depending on the system used to list directory contents, having track 1 as "1" in the filename instead of "01" could cause some systems to output the directory listing with an incorrect track order. Having track 1 start with 1 might then result in the next track in the directory listing be track 10. By forcing the track numbers to always be 2 digits, then every system should display the tracks in the correct order when retrieving the directory listing as "01" "02" etc.

Hope that makes sense. I'm not aware of any albums that are 10-discs +, but maybe having disc numbers be 2 digit as well might be prudent.

@TrazhCant
Copy link
Author

TrazhCant commented Oct 13, 2023

Would a good potential temporary workaround be to jam the zfill() method into the config somehow?

@BB1612
Copy link

BB1612 commented Nov 3, 2023

Depending on the system used to list directory contents, having track 1 as "1" in the filename instead of "01" could cause some systems to output the directory listing with an incorrect track order. Having track 1 start with 1 might then result in the next track in the directory listing be track 10. By forcing the track numbers to always be 2 digits, then every system should display the tracks in the correct order when retrieving the directory listing as "01" "02" etc.

Hope that makes sense. I'm not aware of any albums that are 10-discs +, but maybe having disc numbers be 2 digit as well might be prudent.

Filename {track_number} 2 digits

track.py line 172

output_template = output_template.replace("{track_number}", fix_filename(track_number))

output_template = output_template.replace("{track_number}", '{:02d}'.format(int(fix_filename(track_number))))

@azumukupoe azumukupoe linked a pull request Jul 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants