-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge various prs #169
Open
GitGitro
wants to merge
19
commits into
zotify-dev:main
Choose a base branch
from
GitGitro:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Merge various prs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix _1 filenames, and added m3u8 playlist creation
This reverts commit 94407a1.
Please include this commit diogosena@d3eea11 |
diogosena
reviewed
Aug 1, 2024
D3viantS4ge
reviewed
Aug 3, 2024
@@ -165,11 +166,13 @@ def download_track(mode: str, track_id: str, extra_keys=None, disable_progressba | |||
ext = EXT_MAP.get(Zotify.CONFIG.get_download_format().lower()) | |||
|
|||
output_template = output_template.replace("{artist}", fix_filename(artists[0])) | |||
output_template = output_template.replace("{artists}", fix_filename(', '.join(artists))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the delimiter should be configurable via --md-artistdelimiter
?
@GitGitro I used your version and whenever it comes across a song that I already have in my playlist, it downloads it again but adds a _1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! i've merged various pull requests in order to bring the project a bit up to date and fix some bugs
all credits are in the commits as i have cherry-picked but here are the authors:
@azumukupoe
@uuupah
@diogosena
@D3viantS4ge
@ryansereno
this fixes:
#131 #32 #74 #64 #65 #38 #25 #24