Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make response undefined when status code is 204 #50

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Make response undefined when status code is 204 #50

merged 2 commits into from
Jul 4, 2024

Conversation

ignassew
Copy link
Contributor

@ignassew ignassew commented Jul 3, 2024

When the response is null, it will try to actually return null, which will be incorrect for a 204 response. Example:
Response constructor: Response body is given with a null body status.

Switching null to undefined seems to resolve the problem.

@zoubingwu zoubingwu merged commit cf1949a into zoubingwu:master Jul 4, 2024
1 check passed
@mvhenten mvhenten mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoubingwu zoubingwu zoubingwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignassew @zoubingwu