Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vsce plugin and merge other plugins into repo #81

Merged
merged 23 commits into from
Feb 13, 2023

Conversation

t1m0thyj
Copy link
Contributor

@t1m0thyj t1m0thyj commented Feb 2, 2023

Sorry for the large diff 😢 It may be easier to review without the first commit that just imports code from other repos: d94b2ec...support-zowe-explorer

  • Merge the zowe-actions/octorelease-lerna and zowe-actions/octorelease-script repos into this repository. It should be simpler for us to maintain them in a single Octorelease repo going forward 🙂

    • This means that zowe/zowe-cli will no longer need to include @octorelease/lerna as a dev dependency.
    • Also, zowe-actions/octorelease-script is now deprecated in favor of zowe-actions/octorelease/script in this repo.
  • Add a new plugin for publishing VS Code extensions that can be used by zowe/vscode-extension-for-zowe. It supports the following options:

    Options Description Default
    ovsxPublish Specify true to publish to the OVSX registry. false
    vscePublish Specify false to skip publishing to the VS Code marketplace. true
    vsixDir Path to directory where extension bundle (VSIX) should be generated, or false to skip creating a VSIX. false
  • Update changelog plugin to support displayNames option that defines display names for packages in a monorepo (e.g., "zowe-explorer-ftp-extension" -> "Zowe Explorer Extension for FTP").

  • Update GitHub plugin to create new releases in draft status, and replace createRelease option with publishRelease to be used if the draft release should be published.

  • Support running a plugin multiple times with overridden current working directory ($cwd) and environment variables ($env). For example, to publish 2 VS Code extensions:

    {
      "plugins": [
        ["@octorelease/vsce", {
          "$cwd": "packages/zowe-explorer",
          "vsixDir": "dist"
        }, {
          "$cwd": "packages/zowe-explorer-ftp-extension",
          "vsixDir": "dist"
        }]
      ]
    }
  • Numerous other small enhancements, bug fixes, and dependency updates 🚀

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj marked this pull request as ready for review February 7, 2023 16:52
@t1m0thyj t1m0thyj requested a review from a team February 7, 2023 16:52
@zFernand0
Copy link
Collaborator

For those reviewing, you can also look at the PR view (which offers all the PR review features) and exclude the first commit.
Here is a direct link: https://github.com/zowe-actions/octorelease/pull/81/files/d94b2ecf7428db3583f7eb5f14da16360003084e..a87163b96e620753ae6d5eca64ad67efa3d6a28a

Copy link
Collaborator

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM! 😋
Left a few comments and questions.
I'll go back and resolve the comments once we chat 😉

package.json Show resolved Hide resolved
packages/changelog/README.md Show resolved Hide resolved
packages/changelog/src/version.ts Show resolved Hide resolved
packages/changelog/src/version.ts Show resolved Hide resolved
packages/core/src/doc/IContext.ts Show resolved Hide resolved
packages/npm/src/version.ts Show resolved Hide resolved
packages/vsce/src/init.ts Show resolved Hide resolved
packages/vsce/src/utils.ts Show resolved Hide resolved
packages/vsce/README.md Outdated Show resolved Hide resolved
packages/vsce/src/publish.ts Show resolved Hide resolved
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
@t1m0thyj t1m0thyj merged commit 5456796 into master Feb 13, 2023
@t1m0thyj t1m0thyj deleted the support-zowe-explorer branch February 13, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants