Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix duplicities in the lite lib jar #3808

Merged
merged 13 commits into from
Oct 2, 2024

Conversation

pj892031
Copy link
Contributor

@pj892031 pj892031 commented Sep 30, 2024

Description

The project and lite jars contained multiple versions of the same dependency. It could lead to non-deterministic behavior.

The multiple version of commons-logging.jar (including spring-jcl) is the reason for generating the error message:

Standard Commons Logging discovery in action with `spring-jcl`: please remove `commons-logging.jar` from the classpath in order to avoid potential conflicts

Note: commons-logging.jar cannot be removed at all. The sample application uses it, but the main services use spring-jcl instead.

This PR also enables a lite jar for the new Gateway. It is not necessary to use fatJar. It reduce the size of APIML (saves at least 70MB).

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 1, 2024
Signed-off-by: Pavel Jareš <[email protected]>
Signed-off-by: Pavel Jareš <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 1, 2024
@pj892031 pj892031 marked this pull request as ready for review October 2, 2024 07:55
Signed-off-by: Pavel Jareš <[email protected]>
Copy link

sonarcloud bot commented Oct 2, 2024

@pj892031 pj892031 merged commit 88ca6dc into v3.x.x Oct 2, 2024
27 checks passed
@pj892031 pj892031 deleted the reboot/dependecies-remove-duplicities-2024-09-30 branch October 2, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants