fix(icons-v1): Display icons for all resources

Signed-off-by: zFernand0 <[email protected]>
zowe · Feb 27, 2024 · 88d49aa · 88d49aa
1 parent 68fc2f4
commit 88d49aa
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/.vscode/extension.json b/.vscode/extension.json
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -20,7 +20,6 @@
   // Standardize on the Prettier formatter
   "editor.defaultFormatter": "esbenp.prettier-vscode",
   // Enforce prettier on save
-  "editor.formatOnSave": true,
   "npm.packageManager": "npm",
   "eslint.packageManager": "npm"
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/vsce/CHANGELOG.md b/packages/vsce/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 All notable changes to the "cics-extension-for-zowe" extension will be documented in this file.
 
+## Recent Changes
+
+- BugFix: Fixed icons not displaying.[#112](https://github.com/zowe/cics-for-zowe-client/issues/112)
+- BugFix: Updated dependencies for technical currency
+
 ## `1.3.1`
 
 - BugFix: Updated dependencies for technical currency

diff --git a/packages/vsce/src/utils/getIconPath.ts b/packages/vsce/src/utils/getIconPath.ts
@@ -13,7 +13,9 @@ import { join } from "path";
 
 export function getIconPathInResources(iconFileNameLight: string, iconFileNameDark: string) {
   return {
-    light: join(__dirname, "..", "..", "resources", "imgs", iconFileNameLight),
-    dark: join(__dirname, "..", "..", "resources", "imgs", iconFileNameDark),
+    // We bundle the extension into a single `dist/extension.js`
+    // `__dirname/../resources/imgs === `/path/to/dist/../resources/imgs`
+    light: join(__dirname, "..", "resources", "imgs", iconFileNameLight),
+    dark: join(__dirname, "..", "resources", "imgs", iconFileNameDark),
   };
 }