Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not be able to query SIT parameters on an Inactive ManagedRegion #167

Open
AndrewTwydell opened this issue Dec 13, 2024 · 2 comments · May be fixed by #183
Open

Should not be able to query SIT parameters on an Inactive ManagedRegion #167

AndrewTwydell opened this issue Dec 13, 2024 · 2 comments · May be fixed by #183
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@AndrewTwydell
Copy link
Contributor

Describe the bug

When connected to a plex with active and inactive managed regions, they show up with different icons. Inactive regions still have the ability to right click, Show SIT parameters. We should add a when clause to that menu item to only show when regions are active, and add a check to the CMCI call to prevent the error.

Additional context

Screenshot 2024-12-13 at 4 31 02 PM
Copy link

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@AndrewTwydell AndrewTwydell added the good first issue Good for newcomers label Dec 13, 2024
@enamkhan enamkhan self-assigned this Dec 16, 2024
@davenice
Copy link

I had a little look at this, @enamkhan - didn't quite get as far as deciding how I'd want to manage adding extra bits of context string on, though so I hadn't !

https://github.com/davenice/cics-for-zowe-client/tree/davenice-only-show-sitparms-on-active-region

I think this change just hides the option on regions that are not active. I didn't prevent CMCI from making the request.

@enamkhan enamkhan moved this from New Issues to In Progress in Zowe Explorer for VS Code Dec 19, 2024
@enamkhan enamkhan linked a pull request Dec 24, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants