Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the sit param menu option when a region is inactive #183

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

enamkhan
Copy link
Contributor

@enamkhan enamkhan commented Dec 20, 2024

What It Does
Currently the "Show SIT Parameters" menu option can be selected on inactive regions which will cause an error. I've changed this so that this option is greyed out when the region is inactive. I've also added a check in the command so that the error does not surface when executed from the command palette.

How to Test
Connected to a plex with both active and inactive regions and verified that the menu item for 'Show SIT Parameters' is grayed out when the region is inactive. This will also be the case if multi-select is used and includes an inactive region.

Review Checklist
I certify that I have:

Additional Comments
Resolves #167

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (3786293) to head (5c105f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   93.76%   93.76%           
=======================================
  Files          75       75           
  Lines         770      770           
  Branches       42       43    +1     
=======================================
  Hits          722      722           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enamkhan enamkhan marked this pull request as ready for review December 24, 2024 09:24
Signed-off-by: EKhan <[email protected]>
@enamkhan
Copy link
Contributor Author

Was using enablement to grey out the SIT Param menu option, however this had a side-effect of not showing the option in the command palette. So have changed to just not showing the menu option when the region is inactive.

Signed-off-by: EKhan <[email protected]>
@enamkhan enamkhan changed the title Now greying out the sit param menu item of region is inactive Remove the sit param menu option when a region is inactive Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

Should not be able to query SIT parameters on an Inactive ManagedRegion
2 participants