Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons-v1): Display icons for all resources #115

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

zFernand0
Copy link
Member

What It Does

How to Test

  1. npm i
  2. npm run build
  3. Run the debugger and you should see icons now 😋

Review Checklist
I certify that I have:

Additional Comments

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (7b236db) to head (88d49aa).
Report is 1 commits behind head on zowe-v1-lts.

Additional details and impacted files
@@             Coverage Diff              @@
##           zowe-v1-lts     #115   +/-   ##
============================================
  Coverage        94.17%   94.17%           
============================================
  Files               74       74           
  Lines              755      755           
  Branches            94       92    -2     
============================================
  Hits               711      711           
  Misses              44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zFernand0
Copy link
Member Author

#111 is not a problem in V1 since we were not creating a new instance

@zFernand0 zFernand0 linked an issue Feb 28, 2024 that may be closed by this pull request
Signed-off-by: zFernand0 <[email protected]>
@zFernand0 zFernand0 merged commit 40df6b2 into zowe-v1-lts Feb 29, 2024
8 checks passed
@zFernand0 zFernand0 deleted the fix/icons-v1 branch February 29, 2024 14:01
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Feb 29, 2024
Copy link

Release succeeded for the zowe-v1-lts branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are not displayed in the latest versions of the CICS extension
4 participants