Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code issues v3 #122

Merged
merged 6 commits into from
May 4, 2024
Merged

Fix code issues v3 #122

merged 6 commits into from
May 4, 2024

Conversation

awharn
Copy link
Member

@awharn awharn commented May 1, 2024

What It Does

Fixed several identified problems with possible null values in the tree and web views

How to Test

Review Checklist
I certify that I have:

Additional Comments

zowe-robot and others added 5 commits March 4, 2024 22:01
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn awharn self-assigned this May 1, 2024
@awharn
Copy link
Member Author

awharn commented May 1, 2024

This PR may look a little weird due to an accidental push. Thanks for fixing it @zFernand0.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (9794c46) to head (4aa7d5d).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #122   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       54       55    +1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andrew W. Harn <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@zFernand0 zFernand0 merged commit 54e4b0d into next May 4, 2024
6 checks passed
@zFernand0 zFernand0 deleted the fix-code-issues-v3 branch May 4, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants