Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully specify urls for repo files in VSCE README #156

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

adam-wolfe
Copy link
Contributor

What It Does
Addresses #155

URLs to resources from this repository have been updated to include the full file path.

How to Test
Build and package the extension, and confirm that the URLs to screenshots and other resources work properly.

Review Checklist
I certify that I have:

Additional Comments

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (09e8588) to head (ba8f84d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #156   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       54       55    +1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it so that it works for both, repo + marketplace 🥳

LGTM! 😋

I hit a problem while packaging the extension, but it can be address in a follow up PR if needed.

Should we add a quick changelog to get this fix out the door? 😋

I don't mind doing so later throughout the week though.

@zFernand0 zFernand0 merged commit 1d2db39 into main Oct 21, 2024
17 checks passed
@zFernand0 zFernand0 deleted the fix-readme-urls-2 branch October 21, 2024 17:02
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Oct 21, 2024
Copy link

Release succeeded for the main branch with some errors. ⚠️

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants