Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting condition to read team configuration file. #160

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

chinmdas
Copy link
Contributor

@chinmdas chinmdas commented Dec 9, 2024

What It Does
It does a correct condition checking on whether or not Team Configuration File exists.

How to Test

  • click on + icon
  • Click on "Create a New CICS Profile"
  • zowe.config.json file opens up

Review Checklist
I certify that I have:

Additional Comments

  • Currently, these changes only take care of the condition when a Team Configuration file is available globally.
  • Still investigating the case when Team Configuration file is missing,

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (1d2db39) to head (4ac9823).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       55       54    -1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0
Copy link
Member

Hey @chinmdas,
Could you add a quick changelog entry for this fix? 🙏

Signed-off-by: Chinmay Das <[email protected]>
@chinmdas
Copy link
Contributor Author

Thanks @zFernand0 ,
I have updated the CHANGELOG.md now.

@chinmdas
Copy link
Contributor Author

Hi @JillieBeanSim , Can I get your review on this?

@zFernand0
Copy link
Member

My apologies for the delay.
@JillieBeanSim
If you have a chance to test this, that would be great.
If not, the CICS monorepo doesn't require 2 approvals at the moment, so we can get this merged and published right away 🙏

@zFernand0 zFernand0 merged commit d985dac into zowe:main Dec 12, 2024
13 checks passed
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Dec 12, 2024
@zFernand0
Copy link
Member

@chinmdas chinmdas deleted the team-configuration-file-check branch December 12, 2024 15:58
@davenice
Copy link
Contributor

This is a partial fix for #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants