Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CICS connections breaking other ZE sessions #173

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AndrewTwydell
Copy link
Contributor

Required #171 and #172

What It Does
Changes method of pulling data from CMCI from Axios HTTP requests to the CICS SDK's getResource and getCache methods. Removes the global rejectUnauthorized overrides which broke the other ZE sessions.

Review Checklist
I certify that I have:

Additional Comments
Resolves #159
Resolves #124

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (c56c91c) to head (10de456).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          75       75           
  Lines         776      776           
  Branches       45       44    -1     
=======================================
  Hits          728      728           
  Misses         48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndrewTwydell AndrewTwydell force-pushed the sdk-cache branch 2 times, most recently from 85531d9 to d3b74e1 Compare December 18, 2024 11:21
@AndrewTwydell AndrewTwydell force-pushed the fix-global-ru-overrides branch from 39b54e9 to 7e3de0a Compare December 18, 2024 12:02
Copy link

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of thoughts - look generally good though.

packages/vsce/src/trees/treeItems/CICSLibraryTreeItem.ts Outdated Show resolved Hide resolved
@AndrewTwydell AndrewTwydell force-pushed the fix-global-ru-overrides branch from 37980ec to 21eb530 Compare December 18, 2024 13:53
Base automatically changed from sdk-cache to main December 18, 2024 14:45
@AndrewTwydell AndrewTwydell force-pushed the fix-global-ru-overrides branch from 21eb530 to 788a582 Compare December 18, 2024 14:54
@AndrewTwydell AndrewTwydell force-pushed the fix-global-ru-overrides branch from e9be358 to 10de456 Compare December 18, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
3 participants