Fixing issue in 3.1.0 due to SSH2 external dep. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EKhan <[email protected]>
davenice
approved these changes
Dec 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 74 74
Lines 738 738
Branches 37 38 +1
=======================================
Hits 690 690
Misses 48 48 ☔ View full report in Codecov by Sentry. |
AndrewTwydell
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Thank you! @zFernand0 it's over here rather than an existing PR
zFernand0
added
the
release-patch
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
The PR #165 marks SSH2 as an external dependency for tsup. This breaks the CICS extension - reverting for now.
How to Test
Created the vsix package, which I then installed and tested manually.
Review Checklist
I certify that I have:
Additional Comments
Resolves #174