Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated icons for folder, local file, local transaction, program and … #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rajat-Sahrawat
Copy link
Contributor

@Rajat-Sahrawat Rajat-Sahrawat commented Dec 20, 2024

Updated icons for resource types

@Rajat-Sahrawat
Copy link
Contributor Author

@zFernand0 @JillieBeanSim ready for review

@davenice
Copy link

@Rajat-Sahrawat - we'll need to redo your commit with DCO before it can merge.

Here are some screenshots in situ:
image
image
image
image

Transaction and Task are fairly hard to make out - I'm interested in other opinions though!

Also I noticed one problem which we will need to address - all of the stuff under the web folder seems to default to the Program icon - perhaps there is an icon already there that we can use as a generic resource icon for now and a dev can help tweak the code with a commit on this PR?
image

@davenice
Copy link

and a flavour of high contrast mode - looking good
image

@Rajat-Sahrawat Rajat-Sahrawat force-pushed the icons-for-vs-code-at-plex-level branch from 86aa71c to bd56f6e Compare December 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants