-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional behaviour corrections #186
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Chinmay Das <[email protected]>
Signed-off-by: Chinmay Das <[email protected]>
Signed-off-by: Chinmay Das <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 28.37% 28.14% -0.24%
==========================================
Files 148 146 -2
Lines 5082 5113 +31
Branches 892 899 +7
==========================================
- Hits 1442 1439 -3
- Misses 3640 3674 +34 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chinmay Das <[email protected]>
This PR fixes #179 |
Signed-off-by: Chinmay Das <[email protected]>
I have recorded screen to show you guys the functional testing of CICS Extension.
Screen.Recording.2024-12-24.at.10.01.10.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to address, and some indentation to correct in the comments. Package.json also needs looking at - presumably you've changed the delete/update commands to a manage command, but hard to tell currently.
I also notice a bug where profiles that are already in the tree are not removed from the list of profiles to pick, like the extension currently does.
Screen.Recording.2025-01-07.at.12.16.12.PM.mov
Signed-off-by: Chinmay Das <[email protected]>
Signed-off-by: Chinmay Das <[email protected]>
Thanks for reporting this @AndrewTwydell . I have fixed this...!!! |
Signed-off-by: Chinmay Das <[email protected]>
Signed-off-by: Chinmay Das <[email protected]>
I've have tested this and it seems good to me. I've got a project config file and a global config file. I've tried hiding connections from both. I haven't tried more complex things like having the same name connection in both types of file or similar. Functionally this is taking us in a good direction. |
@AndrewTwydell could you check you're happy with the changes you requested. And if we get a review from @zFernand0 or someone in the Zowe Explorer team I think we're good to put this in later today. (We've got another icon change incoming so perhaps we batch them up) |
What It Does
As part of this PR, we have fixed following scenarios:
Manage Profile
option missing in CICS Explorer when we right click on available CICS Profile.Edit Team Configuration File
option only, where as ZE showsCreate a New Team Configuration File
option as well.Project: in the current working directory
.How to Test
Tested against Zowe Explorer
Review Checklist
I certify that I have:
Additional Comments