-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lint warnings #195
Fix lint warnings #195
Conversation
355dae3
to
bda99b5
Compare
token.onCancellationRequested(() => { | ||
console.log("Cancelling the loading of resources"); | ||
}); | ||
token.onCancellationRequested(() => { }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have removed the unecessary console logs from these methods, but kept the empty method for if we want to add a cancellation action - am willing to debate whether this is a good idea or not
7d6335f
to
a83de6c
Compare
a83de6c
to
5af1054
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing a lot of the lint warnings. 🙏
We often don't worry too much about the cognitive complexity ones. And we understand that the @typescript-eslint/no-unsafe-return
can turn into a more complicated fix 😅
For now though, this PR LGTM! 😋
793ba73
to
4267f18
Compare
Signed-off-by: Andrew Twydell <[email protected]>
4267f18
to
6d8b94d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Partial fix for #146.
Resolves basic lint warnings in packages. Does NOT resolve complexity or
any
return type warnings - these will be in a follow-up PR as they require more refactoring.Introduces a constants file for repeated, magic values throughout the VSCE package.
Review Checklist
I certify that I have: