Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anax test branch #3273
Anax test branch #3273
Changes from 88 commits
9d3213b
67f1b2c
7b3217b
b238c59
9a82333
e0015a7
fceba31
ca5bdc1
ca1ebb5
b4f171a
eb72f4e
258c9a8
47bff3b
7dbac10
390f454
bfc9c4a
7e9bfcf
c996f57
0e1e50f
74b51ec
bf8b953
7866570
06f0fcc
697e351
68cd78c
b799e53
7cd3aea
26e440f
3401449
012de1d
1525e41
7f971f7
b155f0a
9a04302
c2e7ca8
c301259
2a15f81
73004a8
d3df0b3
650cc74
5861c7c
16023b9
a8b329a
45ebb23
07c5f3d
a17b00d
a8bdaf2
ac8cedd
b3e3e58
0cfcf94
971ec24
7991113
ab00c09
3e35574
26e1be9
ac4d5ec
bd4f582
641f4b6
5336073
4fcbc68
0c7af3e
73147f7
2336834
051fca1
c27ab6f
05dab65
fa10ce1
92238e7
18eb624
95b4e85
5fc3ed8
610828d
f5db029
41cff7c
513bf84
038bdfc
2c189f8
81b1296
289d694
66b51c5
3d8471d
2716dbf
44f0acf
46dc2a1
1a2939a
f305024
9e78669
55aecbc
2617e96
28871d3
3893a8e
59bbd1c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, for v3, it seems like a good idea to inform the PR opener to target the v3 branch. Glad we discussed this. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this point is necessary or could perhaps cause someone to open a PR against a different branch than that which was used as the base branch (e.g. someone opens a new branch against docs-staging, but then targets the master branch). Maybe it would be best to say to target the branch that was used to base your PR branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janan07 That would be the intent -- to remind folks that the live changes use the master branch and changes for the future use the docs-staging branch. So if their base branch doesn't align w/ this, then, yep, they'd need to change their branch to align w/ our branching strategy.