Update app to Angular version 18, with package and angular.json (CLI support) changes #71
Conversation
Signed-off-by: zowe-robot <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
Signed-off-by: zowe-robot <[email protected]>
Signed-off-by: Satish Wadkar <[email protected]>
Signed-off-by: Satish Wadkar <[email protected]>
Signed-off-by: Satish Wadkar <[email protected]>
DivergentEuropeans
changed the title
There was a problem hiding this comment.
You are missing "entryPoint" zowe/zlux-app-server#308
Please do
"entryPoint": {
"2.0": "main.js",
"3.0": "v3/main.js"
}
Our build automation is already setup to handle this. It builds v2 content into the web folder alongside v3 content, so they should be separated in that way.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "identifier": "org.zowe.terminal.vt", | |||
| "apiVersion": "2.0.0", | |||
| "pluginVersion": "2.14.0", | |||
| "pluginVersion": "2.18.0", | |||
There was a problem hiding this comment.
that is not semver.
you have made breaking changes. it is v3.0.0
| 'path': path.resolve(__dirname, '../web'), | ||
| 'filename': 'main.js', | ||
| output: { | ||
| path: path.resolve(__dirname, '../web'), |
There was a problem hiding this comment.
web/v3
to isolate it from the v2 content that the build system will populate into the web folder.
| }, | ||
| 'plugins': [ | ||
| plugins: [ |
There was a problem hiding this comment.
CopyWebPackPlugin's "to" needs to be "../web/v3/assets"
Signed-off-by: Satish Wadkar <[email protected]>
| clean: true | ||
| }, | ||
| resolve: { | ||
| alias: { |
There was a problem hiding this comment.
likely needs resolve.extensions = ['.ts', '.js']
| @@ -49,7 +74,7 @@ function deepMerge(base, extension) { | |||
| if (!base[key]) base[key] = {}; | |||
| deepMerge(base[key], extension[key]); | |||
| } else { | |||
| Object.assign(base, {[key]: extension[key]}); | |||
| Object.assign(base, { [key]: extension[key] }); | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
export config to module.exports
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments