Zowe Suite v1.12.0

zowe · May 27, 2020 · eaa1fec · eaa1fec
2 parents 06ce19a + 997982a
commit eaa1fec
Show file tree

Hide file tree

Showing 18 changed files with 44 additions and 66 deletions.
diff --git a/bootstrap/src/uri/dsm-uri.ts b/bootstrap/src/uri/dsm-uri.ts
@@ -22,62 +22,36 @@ export class DsmUri implements ZLUX.UriBroker {
     return proxy_mode ? `/${proxy_path}${url}` : url;
   }
 
-  rasUri(relativePath: string): string {
-    relativePath;//suppress warning for now
+  rasUri(_relativePath: string): string {
     return "";
   }
-  unixFileUri(route: string, absPath: string,
-              sourceEncodingOrOptions?: string|ZLUX.UnixFileUriOptions, targetEncoding?: string,
-               newName?: string, forceOverwrite?: boolean, sessionID?: number,
-               lastChunk?: boolean, responseType?: string): string {
-    //suppress warning for now
-    route;
-    absPath;
-    sourceEncodingOrOptions;
-    targetEncoding;
-    newName;
-    forceOverwrite;
-    sessionID;
-    lastChunk;
-    responseType;
+  unixFileUri(_route: string, _absPath: string,
+              _sourceEncodingOrOptions?: string|ZLUX.UnixFileUriOptions, _targetEncoding?: string,
+              _newName?: string, _forceOverwrite?: boolean, _sessionID?: number,
+              _lastChunk?: boolean, _responseType?: string): string {
     return "";
   }
   omvsSegmentUri(): string {
     return `${this.serverRootUri('omvs')}`;
   }
-  datasetContentsUri(relativePath: string): string {
-    relativePath;//suppress warning for now
+  datasetContentsUri(_relativePath: string): string {
     return "";
   }
-  VSAMdatasetContentsUri(relativePath: string, closeAfter?: boolean): string {
-    relativePath;//suppress warning for now
-    closeAfter;
+  VSAMdatasetContentsUri(_relativePath: string, _closeAfter?: boolean): string {
     return "";
   }
-  datasetMetadataHlqUri(updateCache?: boolean | undefined, types?: string | undefined, workAreaSize?: number | undefined, resumeName?: string | undefined, resumeCatalogName?: string | undefined): string {
-    updateCache;
-    types;
-    workAreaSize;
-    resumeName;
-    resumeCatalogName;
+  datasetMetadataHlqUri(_updateCache?: boolean | undefined, _types?: string | undefined, 
+                        _workAreaSize?: number | undefined, _resumeName?: string | undefined, _resumeCatalogName?: string | undefined): string {
     return "";
   }
-  datasetMetadataUri(relativePath: string, detail?: string | undefined, types?: string | undefined, listMembers?: boolean | undefined, workAreaSize?: number | undefined, includeMigrated?: boolean | undefined, includeUnprintable?: boolean | undefined, resumeName?: string | undefined, resumeCatalogName?: string | undefined, addQualifiers?: string | undefined): string {
-    relativePath;
-    detail;
-    types;
-    listMembers;
-    workAreaSize;
-    includeMigrated;
-    includeUnprintable;
-    resumeName;
-    resumeCatalogName;
-    addQualifiers;
+  datasetMetadataUri(_relativePath: string, _detail?: string | undefined, _types?: string | undefined, 
+                      _listMembers?: boolean | undefined, _workAreaSize?: number | undefined, _includeMigrated?: boolean | undefined, 
+                      _includeUnprintable?: boolean | undefined, _resumeName?: string | undefined, _resumeCatalogName?: string | undefined, 
+                      _addQualifiers?: string | undefined): string {
     return "";
   }
 
-  serverRootUri(uri: string): string {
-    uri;
+  serverRootUri(_uri: string): string {
     return "";
   }
 

diff --git a/system-apps/system-settings-preferences/webClient/src/app/language/language.component.html b/system-apps/system-settings-preferences/webClient/src/app/language/language.component.html
@@ -9,7 +9,7 @@
 -->
 <div class="language-main-window">
   <div class="language-content-left">
-      <img class="language-icon"><hr class="language-separator-hor">
+      <img class="language-icon" alt=""><hr class="language-separator-hor">
       <button class="language-button" (click)="selectEnglish()" title="{{Select}}">English</button><hr class="language-separator-hor">
       <button class="language-button" (click)="selectChinese()" title="{{Select}}">中文</button><hr class="language-separator-hor">
       <button class="language-button" (click)="selectFrench()" title="{{Select}}">Français</button><hr class="language-separator-hor">

diff --git a/...ps/web-browser-app/webClient/src/app/browser/browser-window/browser-window.component.html b/...ps/web-browser-app/webClient/src/app/browser/browser-window/browser-window.component.html
@@ -8,7 +8,7 @@
   Copyright Contributors to the Zowe Project.
 -->
 
-<iframe *ngIf="url else startPage" [src]="url"></iframe>
+<iframe *ngIf="url else startPage" [src]="url" title="Zowe Web Browser"></iframe>
 <ng-template #startPage>
   <div class="zlux-wb-welcome">
     Welcome to Zowe Web Browser

diff --git a/virtual-desktop/src/app/authentication-manager/login/login.component.css b/virtual-desktop/src/app/authentication-manager/login/login.component.css
@@ -180,7 +180,7 @@
 }
 
 .back-button {
-  font-family: 'Roboto-Medium', 'Roboto Medium', 'Roboto';
+  font-family: 'Roboto-Medium', 'Roboto Medium', 'Roboto', sans-serif;
   font-weight: 500;
   font-style: normal;
   font-size: 15px;

diff --git a/virtual-desktop/src/app/context-menu/context-menu.component.css b/virtual-desktop/src/app/context-menu/context-menu.component.css
@@ -58,7 +58,7 @@ li.disabled {
   width: 100%;
   height: auto;
   padding:3px;
-  font-family: 'Helvetica';
+  font-family: 'Helvetica', sans-serif;
   font-size: 14px;
   font-weight: 400;
   white-space:nowrap;
@@ -112,12 +112,12 @@ li.disabled {
   left: 0px;
 }
 
-.context-menu .multi-menu-item>.submenu>com-rs-mvd-context-menu>.context-menu {
+.context-menu .multi-menu-item>.submenu>.mvd-context-menu>.context-menu {
   left: 0;
   top: 0;
 }
 
-.context-menu .multi-menu-item>.submenu>com-rs-mvd-context-menu>.context-menu.propagateChildLeft>ul {
+.context-menu .multi-menu-item>.submenu>.mvd-context-menu>.context-menu.propagateChildLeft>ul {
   position: absolute;
   right: 100%;
 }

diff --git a/virtual-desktop/src/app/context-menu/context-menu.component.html b/virtual-desktop/src/app/context-menu/context-menu.component.html
@@ -41,6 +41,7 @@
                 class="icon"
                 [src]="menuItem.icon ? this.generateIcon(menuItem.icon) : null"
                 [class.hide-icon]="!menuItem.icon"
+                alt=""
               >
               <div>{{menuItem.text}}</div>
             </div>
@@ -65,6 +66,7 @@
             [class.propagateChildLeft]="this._propagateChildLeft"
           >
             <com-rs-mvd-context-menu
+              class='mvd-context-menu'
               [xPos]="-2"
               [yPos]="-5"
               [parentY]="this.newY+(i*this._itemHeight)"
@@ -90,6 +92,7 @@
                 [src]="menuItem.icon ? this.generateIcon(menuItem.icon) : null"
                 [class.hide-icon]="!menuItem.icon"
                 [class.propagateChildLeft]="this._propagateChildLeft"
+                alt=""
               >
               <div>{{menuItem.text}}</div>
             </div>

diff --git a/virtual-desktop/src/app/plugin-manager/plugin-factory/iframe/iframe-plugin.component.html b/virtual-desktop/src/app/plugin-manager/plugin-factory/iframe/iframe-plugin.component.html
@@ -9,7 +9,8 @@
   Copyright Contributors to the Zowe Project.
 -->
 
-  <iframe [id]="iframeId" class="mvd-iframe" frameborder="0" width="100%" height="100%" [src]="startingPage" (mouseover)="iFrameMouseOver($event)"></iframe>
+  <iframe [id]="iframeId" class="mvd-iframe" frameborder="0" width="100%" height="100%" 
+  [src]="startingPage" (mouseover)="iFrameMouseOver($event)" title="Iframe App"></iframe>
 
 <!-- 
   This program and the accompanying materials are

diff --git a/...d-window-manager/launchbar/launchbar-instance-view/launchbar-instance-view.component.html b/...d-window-manager/launchbar/launchbar-instance-view/launchbar-instance-view.component.html
@@ -16,7 +16,7 @@
       <p class="caption truncate">{{getTitleForWindow(windowId)}}</p>
       </div>
       <div class="instance-snapshot" (click)="clicked(windowId)" [style.background-color]="black">
-        <img class="instance-preview" src={{getPreview(i,launchbarItem)}}/>
+        <img class="instance-preview" src={{getPreview(i,launchbarItem)}} alt="{{i}} {{getTitleForWindow(windowId)}}"/>
       </div>
     </div>
   </div>

diff --git a/.../window-manager/mvd-window-manager/launchbar/launchbar-menu/launchbar-menu.component.html b/.../window-manager/mvd-window-manager/launchbar/launchbar-menu/launchbar-menu.component.html
@@ -26,7 +26,7 @@
        (click)="setSearchFocus();">
     <div style="cursor: pointer" class="refresh-plugins" (click)="refresh()">
       {{translation.translate("Refresh Applications")}}
-      <i style="padding: 5px" class="fa fa-refresh" (click)="refresh()"></i>
+      <em style="padding: 5px" class="fa fa-refresh" (click)="refresh()"></em>
     </div>
     <div style="margin: 20px"></div>
     <div #menudiv class="launch-menu-scroller"
@@ -50,7 +50,7 @@
       </div>
     </div>
     <div class="launch-menu-search">
-      <i class="launch-menu-search-icon fa fa-search"></i>
+      <em class="launch-menu-search-icon fa fa-search"></em>
       <input #searchapp class="launch-menu-search-input" type="text" 
         placeholder="{{translation.translate('Search')}}"
         [style.font-size]="menuText"

diff --git a/...ndow-manager/mvd-window-manager/launchbar/launchbar-widget/launchbar-widget.component.css b/...ndow-manager/mvd-window-manager/launchbar/launchbar-widget/launchbar-widget.component.css
@@ -68,7 +68,6 @@
   min-height: 120px;
   position: absolute;
   bottom: 70px;
-  right: 0;
   border-radius: 10px;
   right: 5px;
   background: #dde8f1;
@@ -153,7 +152,6 @@
 
 
 .notification-icon {
-  max-width: 40px;
   max-width: 40px;
   margin-left: 2px;
   margin-top: 2px;

diff --git a/...dow-manager/mvd-window-manager/launchbar/launchbar-widget/launchbar-widget.component.html b/...dow-manager/mvd-window-manager/launchbar/launchbar-widget/launchbar-widget.component.html
@@ -26,13 +26,13 @@ <h6 class="launchbar-plugin-version" [style.color]="color.launchbarMenuText">{{g
   <div class="notification-item" *ngFor="let item of notifications; let i = index" [attr.data-index]="i">
       <div class="outer-container" (click)="focusApplication(i)">
           <div class="notification-icon-container">
-            <img class="notification-icon" [src]="info[i].imgSrc">
+            <img class="notification-icon" [src]="info[i].imgSrc" alt="">
           </div>
           <div class="notification-content">
             <div class="notification-title">{{item['notification'].title}}</div>
             <div class="notification-message">{{item['notification'].message}}</div>
           </div>
-          <img class="delete-notification" (click)="deleteNotification(item);$event.stopPropagation()" [src]="closeImage">
+          <img class="delete-notification" (click)="deleteNotification(item);$event.stopPropagation()" [src]="closeImage" alt="Delete notification">
           <div class="time-container">
             <div class="time">{{item.recievedDate.toLocaleTimeString()}}</div>
             <div class="timeAgo">{{timeSince[i]}}</div>

diff --git a/...indow-manager/mvd-window-manager/launchbar/launchbar-widget/launchbar-widget.component.ts b/...indow-manager/mvd-window-manager/launchbar/launchbar-widget/launchbar-widget.component.ts
@@ -236,6 +236,7 @@ export class LaunchbarWidgetComponent implements MVDHosting.ZoweNotificationWatc
       var h = Math.floor(seconds / 3600);
       var m = Math.floor(seconds % 3600 / 60);
 
+      //TODO: This whole section needs internationalization
       var hDisplay = h > 0 ? h + (h == 1 ? " hour, " : " hours, ") : "";
       var mDisplay = m > 0 ? m + (m == 1 ? " minute " : " minutes ") : "";
 

diff --git a/...rc/app/window-manager/mvd-window-manager/launchbar/shared/snackbar/snackbar.component.css b/...rc/app/window-manager/mvd-window-manager/launchbar/shared/snackbar/snackbar.component.css
@@ -51,7 +51,6 @@
     display: inline-block;
     border-left-style: solid; 
     vertical-align: top;
-    height: 50px;
     position: absolute;
     height: 100%;
     top:0;

diff --git a/...c/app/window-manager/mvd-window-manager/launchbar/shared/snackbar/snackbar.component.html b/...c/app/window-manager/mvd-window-manager/launchbar/shared/snackbar/snackbar.component.html
@@ -13,7 +13,7 @@
 <div class="flex">
   <div class="outer-snackbar-container">
       <div class="snackbar-container">
-          <img class="snackbar-icon" src={{data.imgSrc}}>
+          <img class="snackbar-icon" src={{data.imgSrc}} alt="New notification. {{data.title}} {{data.message}}">
           <div class="snackbar-info">
               <div class="snackbar-title">{{data.title}}</div>
               <div class="snackbar-data">{{data.message}}</div>

diff --git a/...dow-manager/mvd-window-manager/personalization-panel/personalization-panel.component.html b/...dow-manager/mvd-window-manager/personalization-panel/personalization-panel.component.html
@@ -16,7 +16,7 @@
   [style.maxWidth]='this.panelMaxWidth'>
     <ul class="personalization-panel-ul" *ngIf="showPanel">
       <li class="personalization-panel-li" *ngFor="let tool of personalizationTools" (click)="openTool(tool)">
-        <img class="personalization-panel-item panel-item-{{tool.imgSrc}}"><br>
+        <img class="personalization-panel-item panel-item-{{tool.imgSrc}}" alt=""><br>
         <span class="personalization-panel-span">{{tool.title}}</span>
       </li>
     </ul>

diff --git a/...r/mvd-window-manager/personalization-panel/personalization/personalization.component.html b/...r/mvd-window-manager/personalization-panel/personalization/personalization.component.html
@@ -8,13 +8,14 @@
   Copyright Contributors to the Zowe Project.
 -->
 
+<!-- TODO: This page needs internationalization support -->
 <div class="personalization-main-window">
   <label class="personalization-label small back-button top" (click)="goBack()">
-    <i class="fa fa-chevron-left" style="padding: 5px; font-size: large; padding-right: 7px; margin-top: 2px;">
-    </i>Back</label>
+    <em class="fa fa-chevron-left" style="padding: 5px; font-size: large; padding-right: 7px; margin-top: 2px;"></em>Back
+  </label>
 
   <label class="personalization-label small reset-button top" (click)="resetAllDefault()">Reset to Default
-    <i class="fa fa-trash" style="padding: 5px; font-size: large;"></i>
+    <em class="fa fa-trash" style="padding: 5px; font-size: large;"></em>
   </label>
 
   <label class="personalization-label" style="padding-top: 10px;">Background</label>
@@ -49,12 +50,13 @@
   </div>
   <label class="personalization-label">Size</label>
 
+  <!-- Ideally, this would say something like alt="Select Size small" but alt attribute adds a weird artifact -->
   <img [ngClass]="{ 'personalization-preview-item selected': selectedSize == 1,
-    'personalization-preview-item preview-small': true}" (click)="sizeSelected('small')">
+    'personalization-preview-item preview-small': true}" (click)="sizeSelected('small')" alt="">
   <img [ngClass]="{ 'personalization-preview-item selected': selectedSize == 2,
-    'personalization-preview-item preview-medium': true}" (click)="sizeSelected('medium')">
+    'personalization-preview-item preview-medium': true}" (click)="sizeSelected('medium')" alt="">
   <img [ngClass]="{ 'personalization-preview-item selected': selectedSize == 3,
-    'personalization-preview-item preview-large': true}" (click)="sizeSelected('large')">
+    'personalization-preview-item preview-large': true}" (click)="sizeSelected('large')" alt="">
 
     <!-- TODO: Add text re-sizing functionality -->
   <!-- <label class="personalization-label">Text Size</label> -->

diff --git a/virtual-desktop/src/app/window-manager/mvd-window-manager/window/window.component.html b/virtual-desktop/src/app/window-manager/mvd-window-manager/window/window.component.html
@@ -84,7 +84,7 @@
     <com-rs-mvd-viewport [viewportId]="desktopWindow.viewportId" [attr.rs-com-viewport-id]="desktopWindow.viewportId">
       <!-- Loading display -->
       <div class="full-center">
-        <i class="fa fa-spinner fa-spin fa-3x"></i>
+        <em class="fa fa-spinner fa-spin fa-3x"></em>
       </div>
     </com-rs-mvd-viewport>
   </div>

diff --git a/virtual-desktop/src/app/window-manager/simple-window-manager/simple.component.html b/virtual-desktop/src/app/window-manager/simple-window-manager/simple.component.html
@@ -22,14 +22,14 @@ <h1 style="text-align:center" *ngIf="error.length > 0">
     <com-rs-mvd-viewport [viewportId]="viewportId">
       <!-- Loading display -->
       <div class="full-center">
-        <i class="fa fa-spinner fa-spin fa-3x"></i>
+        <em class="fa fa-spinner fa-spin fa-3x"></em>
       </div>
     </com-rs-mvd-viewport>
   </rs-com-login>
   <com-rs-mvd-viewport *ngIf="error.length == 0 && !showLogin" [viewportId]="viewportId">
     <!-- Loading display -->
     <div class="full-center">
-      <i class="fa fa-spinner fa-spin fa-3x"></i>
+      <em class="fa fa-spinner fa-spin fa-3x"></em>
     </div>
   </com-rs-mvd-viewport>
 </div>