Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Auto Save Event #250

Merged
merged 47 commits into from
Aug 16, 2020
Merged

Create Auto Save Event #250

merged 47 commits into from
Aug 16, 2020

Conversation

miteshgoplani
Copy link
Contributor

@miteshgoplani miteshgoplani commented Jul 2, 2020 •
edited
Loading

Added AutoSave Event for Angular, React and Iframe Apps

Dependent on: https://github.com/zowe/zlux-platform/pull/62/files

Signed-off-by: miteshgoplani [email protected]

@miteshgoplani miteshgoplani mentioned this pull request Jul 13, 2020
Merged
@miteshgoplani miteshgoplani changed the title [WIP] Create Auto Save Event Create Auto Save Event Jul 16, 2020
@1000TurquoisePogs
Copy link
Member

I noticed a performance problem: When you close a window, DELETE is called. But, if the window never had autosave data, then the DELETE is not needed. It would be good to have a simple map of each app and whether the app saved data. We could even add this property to the pluginDefinition.json of apps that support the feature
webContent: {
autosave: true
}

Because, if its not supported, then it is not useful to make the server do extra work.

@miteshgoplani
Copy link
Contributor Author

miteshgoplani commented Jul 26, 2020 •
edited
Loading

I noticed a performance problem: When you close a window, DELETE is called. But, if the window never had autosave data, then the DELETE is not needed. It would be good to have a simple map of each app and whether the app saved data. We could even add this property to the pluginDefinition.json of apps that support the feature
webContent: {
autosave: true
}

Because, if its not supported, then it is not useful to make the server do extra work.

@1000TurquoisePogs

  1. Resolved this by adding autosave: true property to pluginDefinition
  2. Updated the Sample Apps PRs

1000TurquoisePogs
1000TurquoisePogs approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

1000TurquoisePogs and others added 18 commits July 31, 2020 02:25
@1000TurquoisePogs @miteshgoplani
Adding app generator first version
981533a 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Make dev plugins folder devPlugins not pluginFolders
4451c5e 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Un-hardcoded plugin id references
c04def6 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Update to validate the ID
1395667 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Version 1
f8b16b5 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Version 2
90b84a2 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Clean-up
23b3428 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
session expire storage evnt,renew session on login
f732b5b 
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
unique session value using timestamp
c0d6bf7 
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
storage key removal, and subscription management
60d6bf1 
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
fixed storage sub and unsub
42af102 
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
clean up messages
d9c2071 
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
updated changelog for 1.12,1.13, *1.14
288dc99 
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Remove double slash for unix api in case it is accidentally done
31e2fe4 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Fix implicit "any"
4653f2e 
Signed-off-by: Leonty Chudinov <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Prototype for actions + recog's by plugin definition
10b019b 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Make idle check only happen if session is renewable
3c39c7a 
Signed-off-by: Leonty Chudinov <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Fixed get logic for recognizers & actions for config location
53e2502 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
DivergentEuropeans and others added 24 commits July 31, 2020 02:26
@DivergentEuropeans @miteshgoplani
Newline/OCD
1476de2 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Added snackbar service to display pop-up for too large images
e5eadf6 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Made pop-up adjust based on desktop size
409df35 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Forgot a small thing
ea38a8f 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Reuse Capabilities declared in zlux-platform
3da4c50 
Signed-off-by: Leonty Chudinov <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Change to use Notification framework
112f984 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Little hack for expirations that are only seen in testing
2dd5379 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Add server-framework.d.ts into tsconfig.ngx-i18n.json
3d7d305 
Signed-off-by: Leonty Chudinov <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
& --> &&
54cf1d6 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Remove unused styles
ad9440f 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@DivergentEuropeans @miteshgoplani
Updated log messages
361a4a6 
Signed-off-by: Leanid Astrakou <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Fixed case in which the URI broker for unixfile would allow 3 or more…
8596376 
… slashes in a row

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
appgen fixes
762d574 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Update package lock
a763dcb 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs @miteshgoplani
Updating app gen icon and angular template icon
91d0397 
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Add AutoSave Event
040a56c 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Fix AutoSave Behavior due to WindowId
20c72ad 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Add AutoSave for Single View App
dc1ce2f 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Handle Multiple Desktop Windows
d19e04a 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Retrieve data for Single Page Apps
db508ca 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Clean AutoSaveData only when first save happens
2362177 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Minor Fix
1849743 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Solve Data-Overwrite issue
9aa12fa 
Signed-off-by: Mitesh <[email protected]>
@miteshgoplani
Check autosave property of plugin before deleting autosave file on wi…
8fe2548 
…ndow close

Signed-off-by: Mitesh <[email protected]>
@1000TurquoisePogs 1000TurquoisePogs merged commit a2e30cf into zowe:staging Aug 16, 2020
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000TurquoisePogs 1000TurquoisePogs 1000TurquoisePogs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miteshgoplani @1000TurquoisePogs @DivergentEuropeans