Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Webpack 4--> 5 across zlux-app-manager #550

Merged
merged 14 commits into from
Nov 16, 2023

Conversation

DivergentEuropeans
Copy link
Member

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

@DivergentEuropeans DivergentEuropeans changed the title Initial base webpack config update for Webpack 5 + app-prop-viewer update for Webpack 4-->5 (WIP) Initial base webpack config update for Webpack 5 + app-prop-viewer update for Webpack 4-->5 Nov 9, 2023
@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 9, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 9, 2023
@DivergentEuropeans DivergentEuropeans changed the title (WIP) Initial base webpack config update for Webpack 5 + app-prop-viewer update for Webpack 4-->5 Webpack 4--> 5 across zlux-app-manager update Nov 10, 2023
@DivergentEuropeans DivergentEuropeans changed the title Webpack 4--> 5 across zlux-app-manager update Webpack 4--> 5 across zlux-app-manager Nov 10, 2023
@DivergentEuropeans DivergentEuropeans requested a review from a team November 10, 2023 14:10
@DivergentEuropeans DivergentEuropeans self-assigned this Nov 10, 2023
@DivergentEuropeans DivergentEuropeans changed the title Webpack 4--> 5 across zlux-app-manager [V3] Webpack 4--> 5 across zlux-app-manager Nov 13, 2023
@DivergentEuropeans DivergentEuropeans changed the base branch from v2.x/staging to v3.x/staging November 13, 2023 13:33
Copy link
Member Author

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify if SVG content still loads

verify if CSS bleed doesn't occur by opening multiple apps at once and see if they conflict with each other (such as a font-size change)

@@ -108,4 +108,3 @@ module.exports = config;

Copyright Contributors to the Zowe Project.
*/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that this is not frequently supported by Webpack and developers should move away from using this

@DivergentEuropeans DivergentEuropeans merged commit 036df42 into v3.x/staging Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants